Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Visual Studio complaints in LLTrans #2575

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix Visual Studio complaints in LLTrans #2575

merged 1 commit into from
Sep 17, 2024

Conversation

Ansariel
Copy link
Contributor

No description provided.

marchcat
marchcat approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marchcat
Copy link
Contributor

This change broke the unit test:

/Users/runner/work/viewer/viewer/indra/newview/tests/lldateutil_test.cpp:60:22: error: out-of-line definition of 'getCountString' does not match any declaration in 'LLTrans'
std::string LLTrans::getCountString(const std::string& language, const std::string& xml_desc, S32 count)
                     ^~~~~~~~~~~~~~
1 error generated.

@Ansariel
Copy link
Contributor Author

Should be fixed now.

@marchcat
Copy link
Contributor

Awesome, thank you!

@marchcat marchcat merged commit f378d2f into secondlife:develop Sep 17, 2024
11 checks passed
@marchcat marchcat added this to the Develop milestone Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@Ansariel Ansariel deleted the develop-lltrans-fixes branch September 17, 2024 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchcat marchcat marchcat approved these changes

Assignees
No one assigned
Labels
c/cpp llui
Projects
None yet
Milestone
Develop
Development

Successfully merging this pull request may close these issues.
2 participants
@Ansariel @marchcat